New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(applications): Don't try to name the charts dir to the same name #2445

Merged
merged 1 commit into from Dec 7, 2018

Conversation

Projects
None yet
3 participants
@agentgonzo
Copy link
Member

agentgonzo commented Dec 7, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

When re-importing a previously imported app, the charts directory already exsists and is named correctly, so don't try to rename it to itself.

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

@jenkins-x-bot jenkins-x-bot requested review from i0n and wbrefvem Dec 7, 2018

@jenkins-x-bot jenkins-x-bot added the size/L label Dec 7, 2018

@agentgonzo agentgonzo force-pushed the agentgonzo:import-chartsdir-already-exists branch from c3a3290 to 16e2f9f Dec 7, 2018

@agentgonzo agentgonzo force-pushed the agentgonzo:import-chartsdir-already-exists branch from 16e2f9f to dfefca4 Dec 7, 2018

@jenkins-x-bot jenkins-x-bot added size/XS and removed size/L labels Dec 7, 2018

@agentgonzo

This comment has been minimized.

Copy link
Member

agentgonzo commented Dec 7, 2018

/retest

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 7, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit f600897 into jenkins-x:master Dec 7, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details

@agentgonzo agentgonzo deleted the agentgonzo:import-chartsdir-already-exists branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment