New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): Handier error message if you get errors pushing to https #2450

Merged
merged 1 commit into from Dec 7, 2018

Conversation

Projects
None yet
3 participants
@agentgonzo
Copy link
Member

agentgonzo commented Dec 7, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

If you try to do a jx import, or jx delete app (new PR) it tries to do a pull request to the environment repos. The URLs for these repos are HTTPS, meaning that if you haven't set up a git credential helper, you will get an error: fatal could not read Username for https://github.com`: No error: exit status 128
This is because the git cli will go "you're not authenticated" and prompt you for a username password, but because we don't attach stdin/out to the git process, it fails.
This error prompts you to do the better thing - check that you have the git credential helper set up so it will automatically pass your creds over to your git repo when doing a write operation.

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

@jenkins-x-bot jenkins-x-bot requested review from jstrachan and rajdavies Dec 7, 2018

@jenkins-x-bot jenkins-x-bot added the size/S label Dec 7, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit d9e8d65 into jenkins-x:master Dec 7, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment