New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new option to avoid waiting for merge build success as tide isn't updating status #2410 #2453

Merged
merged 2 commits into from Dec 7, 2018

Conversation

Projects
None yet
4 participants
@rawlingsj
Copy link
Member

rawlingsj commented Dec 7, 2018

No description provided.

@jenkins-x-bot jenkins-x-bot requested review from amuniz and garethjevans Dec 7, 2018

@jenkins-x-bot jenkins-x-bot added the size/M label Dec 7, 2018

@rawlingsj

This comment has been minimized.

Copy link
Member

rawlingsj commented Dec 7, 2018

/hold might add an improvement

@rawlingsj

This comment has been minimized.

Copy link
Member

rawlingsj commented Dec 7, 2018

/hold

@rawlingsj rawlingsj force-pushed the rawlingsj:master branch from 28e2628 to f8c6ebb Dec 7, 2018

@jenkins-x-bot jenkins-x-bot removed the lgtm label Dec 7, 2018

@rawlingsj rawlingsj changed the title fix(promote): check for --no-wait when performing automatic promotes add a new option to avoid waiting for merge build success as tide isn't updating status #2410 Dec 7, 2018

@rawlingsj

This comment has been minimized.

Copy link
Member

rawlingsj commented Dec 7, 2018

/test bdd

1 similar comment
@rawlingsj

This comment has been minimized.

Copy link
Member

rawlingsj commented Dec 7, 2018

/test bdd

@rawlingsj

This comment has been minimized.

Copy link
Member

rawlingsj commented Dec 7, 2018

/hold cancel

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 7, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ccojocar,garethjevans]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rawlingsj

This comment has been minimized.

Copy link
Member

rawlingsj commented Dec 7, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot merged commit 0ad16fa into jenkins-x:master Dec 7, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details

jtnord added a commit to jtnord/jx that referenced this pull request Jan 4, 2019

fix(login) : login now works on systems without io-notify
when tailing the netlog if the system did not support ionotify then we
would not see any new changes to the file.  witching ot polling on all
systems as the overhead of doing this is minimal.

fixes jenkins-x#2453

@jtnord jtnord referenced this pull request Jan 4, 2019

Merged

fix(login) : login now works on systems without io-notify #2597

2 of 2 tasks complete

jtnord added a commit to jtnord/jx that referenced this pull request Jan 4, 2019

fix(login) : login now works on systems without io-notify
when tailing the netlog if the system did not support ionotify then we
would not see any new changes to the file.  witching ot polling on all
systems as the overhead of doing this is minimal.

fixes jenkins-x#2453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment