New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(uninstall): make uninstall command test state independent #2456

Merged
merged 2 commits into from Dec 7, 2018

Conversation

Projects
None yet
3 participants
@ccojocar
Copy link
Member

ccojocar commented Dec 7, 2018

Submitter checklist

  • [ x] Change is code complete and matches issue description.
  • [ x] Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

@jenkins-x-bot jenkins-x-bot requested review from agentgonzo and rawlingsj Dec 7, 2018

@jenkins-x-bot jenkins-x-bot added the size/S label Dec 7, 2018

@ccojocar ccojocar changed the title <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first PR, read our contributor guidelines https://jenkins-x.io/contribute/ 2. Follow these instructions to write commit messages http://karma-runner.github.io/3.0/dev/git-commit-msg.html 3. Follow these instructions to write tests https://jenkins-x.io/contribute/development/#testing 4. You can trigger the tests for your PR with /test bdd 5. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews 6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests --> test(uninstall): make uninstall command test state independent Dec 7, 2018

@@ -213,6 +213,9 @@ func (o *UninstallOptions) cleanupConfig() error {
if err != nil {
return nil
}
if authConfigSvc == nil {

This comment has been minimized.

@agentgonzo

agentgonzo Dec 7, 2018

Member

you could just put this as

if err != nil || authConfigSvc == nil {

@jenkins-x-bot jenkins-x-bot removed the lgtm label Dec 7, 2018

@agentgonzo

This comment has been minimized.

Copy link
Member

agentgonzo commented Dec 7, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added the lgtm label Dec 7, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agentgonzo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 0501b24 into jenkins-x:master Dec 7, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment