New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lets use the teams StorageLocation settings in `jx step collect` #2458

Merged
merged 7 commits into from Dec 8, 2018

Conversation

Projects
None yet
3 participants
@jstrachan
Copy link
Member

jstrachan commented Dec 7, 2018

No description provided.

@jenkins-x-bot jenkins-x-bot requested review from amuniz and pmuir Dec 7, 2018

@jenkins-x-bot jenkins-x-bot added the size/L label Dec 7, 2018

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 7, 2018

@pmuir does the above all seem OK with you? its a little bit of a change to what you had before

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 7, 2018

btw we have gits.ParseGitURL(text) to avoid using a regex

@jstrachan jstrachan force-pushed the jstrachan:fixes5 branch from 17ed030 to 9de3654 Dec 8, 2018

fix: lets not fail if no secrets.yaml or no vault
as often staging/production doesn't have secrets
@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 8, 2018

/test bdd

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 8, 2018

/retest

@jenkins-x-bot jenkins-x-bot merged commit 658f6b3 into jenkins-x:master Dec 8, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment