New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jenkins): use only the new API to generate tokens #2460

Merged
merged 1 commit into from Dec 8, 2018

Conversation

Projects
None yet
3 participants
@ccojocar
Copy link
Member

ccojocar commented Dec 7, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Use only the new API to generate tokens.
Remove the old way to generate Jenkins API token since now the migration to the new version is done.

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

fix(jenkins): use only the new API to generate tokens
Remove the old way to generate Jenkins API token since now the migration to the new version is done.

@jenkins-x-bot jenkins-x-bot requested review from amuniz and rawlingsj Dec 7, 2018

@jenkins-x-bot jenkins-x-bot added the size/L label Dec 7, 2018

@ccojocar ccojocar requested review from jstrachan and jglick and removed request for amuniz and rawlingsj Dec 7, 2018

@rawlingsj

This comment has been minimized.

Copy link
Member

rawlingsj commented Dec 7, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 8, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot merged commit 4e1a57e into jenkins-x:master Dec 8, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment