New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why would the help for `jx update webhooks` claim it is not implemented? #2462

Merged
merged 2 commits into from Dec 9, 2018

Conversation

Projects
None yet
3 participants
@jglick
Copy link
Contributor

jglick commented Dec 7, 2018

#2113 introduced a command but this bit of help text seems to have been forgotten.

As an aside, I find the behavior when --repo is missing to be odd. It is enumerating all repositories in the org, then updating the per-repo webhook. Why would you not simply update the organization webhook (once)? Is it because some orgs in the repo might have unrelated endpoints?

@jglick jglick requested a review from garethjevans Dec 7, 2018

@jenkins-x-bot jenkins-x-bot requested a review from ccojocar Dec 7, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 9, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit bbd2d1c into jenkins-x:master Dec 9, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details

@jglick jglick deleted the jglick:yes-actually-implemented branch Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment