New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lets ensure we detect termination of knative builds #2466

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
3 participants
@jstrachan
Copy link
Member

jstrachan commented Dec 10, 2018

as sometimes we missed the termination

fix: lets ensure we detect termination of knative builds
as sometimes we missed the termination

@jenkins-x-bot jenkins-x-bot requested review from jtnord and rawlingsj Dec 10, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 10, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 10, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 10, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot merged commit 75b61b8 into jenkins-x:master Dec 10, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment