New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use brew if available to install helm #2471

Merged
merged 2 commits into from Dec 10, 2018

Conversation

Projects
None yet
3 participants
@garethjevans
Copy link
Member

garethjevans commented Dec 10, 2018

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

fixes #

@jenkins-x-bot jenkins-x-bot requested review from agentgonzo and ccojocar Dec 10, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 10, 2018

This won't fix #2062 but should help reduce the load against github.com

@jenkins-x-bot jenkins-x-bot added size/S and removed size/XS labels Dec 10, 2018

@garethjevans garethjevans self-assigned this Dec 10, 2018

@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Dec 10, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 10, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmuir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 4c20c7b into jenkins-x:master Dec 10, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment