New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(install): revamp the git auth configuration and make the organization selectable for environment repositories #2474

Merged
merged 12 commits into from Dec 11, 2018

Conversation

Projects
None yet
3 participants
@ccojocar
Copy link
Member

ccojocar commented Dec 10, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #2395

@jenkins-x-bot jenkins-x-bot requested review from jtnord and rawlingsj Dec 10, 2018

@ccojocar ccojocar requested review from jstrachan and removed request for jtnord Dec 10, 2018

@ccojocar ccojocar force-pushed the ccojocar:fix-org-selection-for-environments branch 2 times, most recently from 4960d6c to 91e0a7f Dec 11, 2018

@ccojocar ccojocar requested a review from garethjevans Dec 11, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 11, 2018

/test bdd

@ccojocar ccojocar force-pushed the ccojocar:fix-org-selection-for-environments branch from 91e0a7f to 88c17bb Dec 11, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 11, 2018

/test bdd

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 11, 2018

/retest

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 11, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 11, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit df43ff6 into jenkins-x:master Dec 11, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment