New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jx upgrade extensions repository #2476

Merged
merged 1 commit into from Dec 11, 2018

Conversation

Projects
None yet
3 participants
@Vlatombe
Copy link
Contributor

Vlatombe commented Dec 11, 2018

  • Move some functions from step_split_monorepo to common_git. They were misplaced.
  • gits.ParseGitURL doesn't recognize github.com/org/repo, pass org/repo instead.

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

This should fix build issues seen at jenkins-x/jenkins-x-extensions#30

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

Fix jx upgrade extensions repository
- Move some functions from step_split_monorepo to common_git. They were misplaced.
- gits.ParseGitURL doesn't recognize github.com/org/repo, pass org/repo instead.

@Vlatombe Vlatombe requested a review from pmuir Dec 11, 2018

@jenkins-x-bot jenkins-x-bot requested review from markawm and rajdavies Dec 11, 2018

@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Dec 11, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 11, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmuir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 127cdc5 into jenkins-x:master Dec 11, 2018

1 of 2 checks passed

tide Not mergeable. Needs updatebot label.
Details
serverless-jenkins succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment