New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: `jx add app` error if no repo defined #2479

Merged
merged 1 commit into from Dec 11, 2018

Conversation

Projects
None yet
4 participants
@pmuir
Copy link
Member

pmuir commented Dec 11, 2018

  • also add a default repository

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

fix: `jx add app` error if no repo defined
* also add a default repository

@jenkins-x-bot jenkins-x-bot requested review from jtnord and rawlingsj Dec 11, 2018

@garethjevans-bot

This comment has been minimized.

Copy link

garethjevans-bot commented Dec 11, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 11, 2018

@garethjevans-bot: changing LGTM is restricted to assignees, and only jenkins-x/jx repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 11, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 11, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans, garethjevans-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit c740323 into jenkins-x:master Dec 11, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment