New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(istio-addon): changed directory that istio is unziped in from outputDir to binDir. #2486

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
5 participants
@martijnburger
Copy link
Contributor

martijnburger commented Dec 11, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • [?] Change is covered by existing or new tests.

Description

Trying to jx create addon istio on a windows system fails because Windows is using the zipped archive. The zipped archive is unzipped to the outputDir, which is outputDir := filepath.Join(binDir, "istio-"+latestVersion.String()) This causes the unzipped Istio resources to be created in istio-1.0.4\istio-1.0.4\ instead of isitio-1.0.4\ when jx is trying to install the resources it is looking in istio-1.0.4\ and not in istio-1.0.4\istio-1.0.4\ and therefor fails to install istio. As also for the UnTargzAll method the Unzip method needs to write the files to the binDir and not the outputDir.

Special notes for the reviewer(s)

This is my first PR and first golang code. Please be gentle. Not sure if this code was covered by existing unit tests, but I could not find any. I am not experienced enough in golang to write any new unit tests myself.

Which issue this PR fixes

fixes #2477

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 11, 2018

Hi @martijnburger. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@martijnburger martijnburger changed the title Changed istio outputDir to binDir for unzip method fix(istio-addon): changed directory that istio is unziped in from outputDir to binDir. Dec 11, 2018

@martijnburger

This comment has been minimized.

Copy link
Contributor

martijnburger commented Dec 11, 2018

/assign @amuniz

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 12, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 12, 2018

/ok-to-test

@jenkins-x-bot jenkins-x-bot merged commit 1117e1f into jenkins-x:master Dec 12, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment