New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some git provider refactoring #2487

Merged
merged 5 commits into from Dec 12, 2018

Conversation

Projects
None yet
4 participants
@wbrefvem
Copy link
Member

wbrefvem commented Dec 11, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

This is part of a bigger refactoring I'm working on that will result in more encapsulation of individual git providers and other components.

wbrefvem added some commits Dec 11, 2018

@jenkins-x-bot jenkins-x-bot requested review from ccojocar and pmuir Dec 11, 2018

@jenkins-x-bot jenkins-x-bot removed the lgtm label Dec 12, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 12, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 12, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ccojocar,garethjevans]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 12, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot merged commit f716aeb into jenkins-x:master Dec 12, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment