New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add git provider user to User #2493

Merged
merged 2 commits into from Dec 12, 2018

Conversation

Projects
None yet
4 participants
@pmuir
Copy link
Member

pmuir commented Dec 12, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Dec 12, 2018

@ccojocar can we auto-populate this new field when the user logs in using Dex if they use GitHub to login?

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 12, 2018

@pmuir This would be nice but unfortunately this information is not provided by dex which intermediates the authentication with GitHub.

dex issues a new ID token which is independent of the downstream IdP, this token has the following claims:
https://github.com/jenkins-x/dex/blob/432a5da2252c3f22b5f882b8dcc1c4ed8b1c0678/server/oauth2.go#L242.

@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Dec 12, 2018

That's a shame - oh well :-(

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 12, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 12, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 0cc165a into jenkins-x:master Dec 12, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment