New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets): clean up the old jenkins-git-credentials secret #2502

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
None yet
3 participants
@ccojocar
Copy link
Member

ccojocar commented Dec 13, 2018

This secret does not seems to be used anymore by the pipeline.

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Remove the old and unused jenkins-git-credentials secret from code. This is also the cleanup from the platform jenkins-x/jenkins-x-platform#4502

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

@ccojocar ccojocar requested review from jstrachan and rawlingsj and removed request for agentgonzo Dec 13, 2018

fix(secrets): clean up the old jenkins-git-credentials secret
This secret does not seems to be used anymore by the pipeline.

@ccojocar ccojocar force-pushed the ccojocar:clean-git-secrets branch from 9525a5d to ed7ceed Dec 13, 2018

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 13, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 13, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 13, 2018

/retest

2 similar comments
@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 13, 2018

/retest

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 13, 2018

/retest

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 14, 2018

/test bdd

1 similar comment
@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 14, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot merged commit b0e57a9 into jenkins-x:master Dec 14, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment