New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewers #2506

Merged
merged 2 commits into from Dec 19, 2018

Conversation

Projects
None yet
4 participants
@pmuir
Copy link
Member

pmuir commented Dec 14, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

@jenkins-x-bot jenkins-x-bot requested review from garethjevans and rawlingsj Dec 14, 2018

@pmuir pmuir force-pushed the pmuir:reviewers branch from af9aed1 to bd09f8a Dec 14, 2018

@jenkins-x-bot jenkins-x-bot added size/L and removed size/M labels Dec 14, 2018

@pmuir pmuir force-pushed the pmuir:reviewers branch from bd09f8a to 9a93baf Dec 14, 2018

@jenkins-x-bot jenkins-x-bot added size/M and removed size/L labels Dec 14, 2018

@pmuir pmuir force-pushed the pmuir:reviewers branch from 9a93baf to 9165672 Dec 19, 2018

@pmuir pmuir changed the title wip: Reviewers Reviewers Dec 19, 2018

@pmuir pmuir force-pushed the pmuir:reviewers branch from 9165672 to 5316137 Dec 19, 2018

@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Dec 19, 2018

/test this
/test bdd

@rawlingsj

This comment has been minimized.

Copy link
Member

rawlingsj commented Dec 19, 2018

/lgtm

@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Dec 19, 2018

/test this

1 similar comment
@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Dec 19, 2018

/test this

@jenkins-x-bot jenkins-x-bot removed the lgtm label Dec 19, 2018

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 19, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 19, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan, rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jstrachan,rawlingsj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 9af6faa into jenkins-x:master Dec 19, 2018

1 of 2 checks passed

tide Not mergeable. Needs updatebot label.
Details
serverless-jenkins succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment