New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide the error about missing apt-get/yum #2508

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
None yet
3 participants
@pmuir
Copy link
Member

pmuir commented Dec 14, 2018

We need to redirect both stdout and stderr to /dev/null so that we don’t see an error when one of them doesn’t exist

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

fix: hide the error about missing apt-get/yum
We need to redirect both stdout and stderr to /dev/null so that we don’t see an error when one of them doesn’t exist

@jenkins-x-bot jenkins-x-bot requested review from ccojocar and rajdavies Dec 14, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 14, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 14, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 1b94c17 into jenkins-x:master Dec 14, 2018

1 of 2 checks passed

tide Not mergeable. Needs updatebot label.
Details
serverless-jenkins succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment