Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
EKS cluster creation should deal with rolled back stacks #2511
If EKS cluster creation process is interrupted or if cluster with given name already exists, there will be CloudFormation stack in ROLLBACK_COMPLETE state left. Such dead stack prevents eksctl from creating cluster with the same name. This is common activity then to remove stacks like this and this function performs this action.
This PR detects such dead stacks and deletes them before creating the cluster with eksctl.
Also we should try to detect that cluster with given name exists before running eksctl, otherwise we end up with CloudFormation stack being initialized and failing after some time. If we know that cluster with given name already exists, we should just detect this fact and inform user about it as soon as possible. This PR implements this as well.
Hi @hekonsek. Thanks for your PR.
I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ccojocar
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing