New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install): store the amdin secrets in vault and to not print the admin password in logs if vault is enabled #2513

Merged
merged 3 commits into from Dec 18, 2018

Conversation

Projects
None yet
4 participants
@ccojocar
Copy link
Member

ccojocar commented Dec 14, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

@jenkins-x-bot jenkins-x-bot requested review from markawm and mikecirioli Dec 14, 2018

@ccojocar ccojocar requested review from rawlingsj , garethjevans and jstrachan and removed request for mikecirioli and markawm Dec 14, 2018

@ccojocar ccojocar force-pushed the ccojocar:jenkins-admin-vault branch from df7eb4b to 86aad50 Dec 14, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 15, 2018

/hold

It needs a bit more work to save the admin credentials in user friendly form which should make the password rotation easier.

@ccojocar ccojocar force-pushed the ccojocar:jenkins-admin-vault branch 2 times, most recently from a4876e4 to 80b6c3c Dec 17, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 18, 2018

/hold cancel

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 18, 2018

/test bdd

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 18, 2018

/lgtm

@ccojocar ccojocar force-pushed the ccojocar:jenkins-admin-vault branch from 80b6c3c to 88cc485 Dec 18, 2018

@jenkins-x-bot jenkins-x-bot removed the lgtm label Dec 18, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 18, 2018

@jstrachan Please could you add again the lgtm label? Thanks

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 18, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 18, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans, jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [garethjevans,jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit f6f1699 into jenkins-x:master Dec 18, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment