New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a top level command to create new projects #2520

Merged
merged 3 commits into from Dec 17, 2018

Conversation

Projects
None yet
5 participants
@jstrachan
Copy link
Member

jstrachan commented Dec 15, 2018

No description provided.

@jenkins-x-bot jenkins-x-bot requested review from pmuir and wbrefvem Dec 15, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 15, 2018

/lgtm

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 15, 2018

/retest

1 similar comment
@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 15, 2018

/retest

@jenkins-x-bot jenkins-x-bot removed the lgtm label Dec 15, 2018

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 15, 2018

/retest

createSpringName = "Create new Spring Boot microservice"
importDirName = "Import existing code from a directory"
importGitName = "Import code from a git repository"
importGitHubName = "Import code from a github repository"

This comment has been minimized.

@ccojocar

ccojocar Dec 17, 2018

Member

I wondering if these shouldn't be more generic than just GitHub.

This comment has been minimized.

@jstrachan

jstrachan Dec 18, 2018

Member

yeah - we should be able to support importing from any git repository I think; we should probably fix that in jx import too

},
}

cmd := &cobra.Command{

This comment has been minimized.

@ccojocar

ccojocar Dec 17, 2018

Member

We should maybe retie the other commands for simplicity and always instruct the user to use the create project command instead of create quickstart or import.

This comment has been minimized.

@jstrachan

jstrachan Dec 18, 2018

Member

though I do like the specific commands too - it also allows much more powerful CLI options and completion

This comment has been minimized.

@jstrachan

jstrachan Dec 18, 2018

Member

the top level jx create project acts as a handy wizard to get folks going until they learn the lower level richer commands I guess?

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 17, 2018

/test bdd

1 similar comment
@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 17, 2018

/test bdd

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 17, 2018

/test bdd

}

func (o *CreateProjectWizardOptions) importGit() error {
repoUrl, err := util.PickValue("Which git repository URL to inmport: ", "", true,

This comment has been minimized.

@houndci-bot

houndci-bot Dec 17, 2018

Collaborator

var repoUrl should be repoURL

case importGitHubName:
return o.importGithubProject()
default:
return fmt.Errorf("Unknown selection: %s\n", name)

This comment has been minimized.

@houndci-bot

houndci-bot Dec 17, 2018

Collaborator

error strings should not be capitalized or end with punctuation or a newline

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 17, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added the lgtm label Dec 17, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 17, 2018

/test bdd

1 similar comment
@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 17, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot merged commit ff13ffe into jenkins-x:master Dec 17, 2018

3 checks passed

Hound 2 violations found.
serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment