New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(install): use client-only mode to install the Helm secrets plugin. #2525

Merged
merged 3 commits into from Dec 17, 2018

Conversation

Projects
None yet
5 participants
@markawm
Copy link
Member

markawm commented Dec 17, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

On a clean system with no previous jx install, there will be no existing K8S context. During the auto-installation of helm, helm init is run, which tries to install the tiller server
into the cluster and will fail because it hasn't been created yet. Since the actual requirement at this stage of the process is only to install the helm client, and the (client-side)
secrets plugin, Run configure the helmer for client only mode to avoid trying to install tiller. Later, when the cluster has been created tiller will still get installed via a later
Helmer.init() call.

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #2507

@jenkins-x-bot jenkins-x-bot requested review from amuniz and garethjevans Dec 17, 2018

@markawm

This comment has been minimized.

Copy link
Member

markawm commented Dec 17, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 17, 2018

/test bdd

@romainverduci

This comment has been minimized.

Copy link
Member

romainverduci commented Dec 17, 2018

lgtm

@jenkins-x-bot jenkins-x-bot removed the lgtm label Dec 17, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 17, 2018

/test bdd

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 17, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added the lgtm label Dec 17, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ccojocar,garethjevans]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 5e55252 into jenkins-x:master Dec 17, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment