New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extravalues files #2540

Merged
merged 2 commits into from Dec 20, 2018

Conversation

Projects
None yet
3 participants
@markawm
Copy link
Member

markawm commented Dec 19, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Just a small one to remove an extraValues.yaml that shouldn't have been checked in, and tidy up .gitignore a bit to prevent this.

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

@jenkins-x-bot jenkins-x-bot requested review from agentgonzo and i0n Dec 19, 2018

@markawm

This comment has been minimized.

Copy link
Member

markawm commented Dec 19, 2018

/test this

1 similar comment
@markawm

This comment has been minimized.

Copy link
Member

markawm commented Dec 19, 2018

/test this

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 20, 2018

/test this

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 0a49f68 into jenkins-x:master Dec 20, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment