fix for create env on prow and add filtering to jx get build log on tekton #3286
Conversation
| @@ -502,7 +502,7 @@ func (o *GetBuildLogsOptions) loadPipelines(kubeClient kubernetes.Interface, tek | |||
| log.Warnf("Error creating PipelineRunInfo for PipelineRun %s: %s\n", pr.Name, err) | |||
| return names, defaultName, buildMap, pipelineMap, err | |||
| } | |||
| if pri != nil { | |||
| if pri != nil && o.BuildFilter.BuildMatches(pri.ToBuildPodInfo()) { | |||
There was a problem hiding this comment.
I think we'll eventually want to change BuildFilter to be a PipelineRunInfoFilter, but it does seem easier to just keep it compatible for now.
There was a problem hiding this comment.
yeah - or we could have a filter interface which we support on both BuildRunInfo and PipeilneRunInfo that both take the filter parmeters and do their thing
|
/lgtm |
|
/test this |
for `jx create jenkins token`
for `jx create jenkins token`
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, garethjevans The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test this |
No description provided.