chore: Switch to sigs.k8s.io/yaml #3380
Conversation
This will let us incorporate k8s and Tekton types directly into jenkins-x.yml - previously, we'd have trouble with that due to the use of JSON struct tags in k8s/Tekton/etc, so that the default golang YAML library would not unmarshal correctly. This did require changing `loop_step/jenkins-x.yml` - a bare `- on` as part of a string slice (or `foo: on` for a string field) would end up unmarshalling as the string `true`, so yeah, `on`, `off`, `t`, `f`, etc do need to be quoted if they're supposed to result in strings now.
| Password string `yaml:"password,omitempty" json:"password"` | ||
| Kind UserKind `yaml:"kind"` | ||
| Username string `json:"username"` | ||
| ApiToken string `json:"apitoken"` |
There was a problem hiding this comment.
struct field ApiToken should be APIToken
There was a problem hiding this comment.
baaaaah not much I can do here since the field already was defined.
|
/test bdd |
|
@abayer FYI we use for GitOps the cc @jstrachan |
|
@ccojocar If we can use |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rawlingsj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
Submitter checklist
Description
This will let us incorporate k8s and Tekton types directly into
jenkins-x.yml - previously, we'd have trouble with that due to the use
of JSON struct tags in k8s/Tekton/etc, so that the default golang YAML
library would not unmarshal correctly.
This did require changing
loop_step/jenkins-x.yml- a bare- onaspart of a string slice (or
foo: onfor a string field) would end upunmarshalling as the string
true, so yeah,on,off,t,f,etc do need to be quoted if they're supposed to result in strings now.
(this will make #3312 and #3366 easier to implement)
Special notes for the reviewer(s)
Which issue this PR fixes
n/a