Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/no app exit code #3535

Merged
merged 3 commits into from Apr 4, 2019
Merged

Fix/no app exit code #3535

merged 3 commits into from Apr 4, 2019

Conversation

dgozalo
Copy link
Contributor

@dgozalo dgozalo commented Apr 4, 2019

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

This is a PR from Ivan Meredith's branch, as we need to get it merged now.

imeredith and others added 3 commits April 3, 2019 18:21
@dgozalo
Copy link
Contributor Author

dgozalo commented Apr 4, 2019

/cc @pmuir
/cc @hferentschik

@pmuir
Copy link
Contributor

pmuir commented Apr 4, 2019

/lgtm

@jenkins-x-bot-test
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmuir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmuir
Copy link
Contributor

pmuir commented Apr 4, 2019

Fixes #3349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants