Skip to content
Permalink
Browse files
[JENKINS-50790] Address feedback
  • Loading branch information
raul-arabaolaza committed Apr 17, 2018
1 parent 81589c3 commit 7ba7a3983ac1d09da5ded9ec134f205e7383782c
@@ -80,8 +80,8 @@

public static final String DOM_MAX_SCRIPT_RUN_TIME = "dom.max_script_run_time";
public static final String DOM_MAX_CHROME_SCRIPT_RUN_TIME = "dom.max_chrome_script_run_time";
public static int PAGE_LOAD_TIMEOUT = 30;
public static int IMPLICIT_WAIT_TIMEOUT = 1;
public static final int PAGE_LOAD_TIMEOUT = 30;
public static final int IMPLICIT_WAIT_TIMEOUT = 1;

@Override
protected void configure() {
@@ -228,12 +228,16 @@ public boolean installPlugins(final PluginSpec... specs) throws UnableToResolveD
}
}
} else {

// JENKINS-50790 It seems that this page takes too much time to load when running in the new ci.jenkins.io
driver.manage().timeouts().pageLoadTimeout(time.seconds(60), TimeUnit.MILLISECONDS);
visit("available");
driver.manage().timeouts().pageLoadTimeout(time.seconds(FallbackConfig.PAGE_LOAD_TIMEOUT), TimeUnit.MILLISECONDS);
try {
driver.manage().timeouts().pageLoadTimeout(time.seconds(60), TimeUnit.MILLISECONDS);
visit("available");
} finally {
driver.manage().timeouts().pageLoadTimeout(time.seconds(FallbackConfig.PAGE_LOAD_TIMEOUT), TimeUnit.MILLISECONDS);
}
// End JENKINS-50790

final ArrayList<PluginSpec> update = new ArrayList<>();
for (final PluginSpec n : specs) {
switch (installationStatus(n)) {

0 comments on commit 7ba7a39

Please sign in to comment.