Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-29922] Testing use of symbols in a realistic context #167

Merged
merged 2 commits into from Aug 10, 2016

Conversation

Projects
None yet
3 participants
@jglick
Copy link
Member

jglick commented Aug 5, 2016

Requires jenkinsci/junit-plugin#53 to actually pass.

@reviewbybees esp. @kohsuke

[JENKINS-29922] Testing use of symbols in a realistic context.
Actually fails with junit 1.15 but will pass in 1.16.
@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Aug 5, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick

This comment has been minimized.

Copy link
Member Author

jglick commented Aug 8, 2016

Trying to get a release of junit, but currently blocked by Artifactory authentication problems.

@jglick

This comment has been minimized.

Copy link
Member Author

jglick commented Aug 9, 2016

@olivergondza you maintain this right?

@jglick

This comment has been minimized.

Copy link
Member Author

jglick commented Aug 9, 2016

Note that the modified tests are being skipped, though Jenkins does not report the reason (bug in the junit plugin I suppose).

@olivergondza

This comment has been minimized.

Copy link
Member

olivergondza commented Aug 9, 2016

👍

@olivergondza

This comment has been minimized.

Copy link
Member

olivergondza commented Aug 9, 2016

Note that the modified tests are being skipped, though Jenkins does not report the reason (bug in the junit plugin I suppose).

The JUnit XML reports merely note it was skipped without the reason - not sure something can be done about that). ATH put that reason on stderr (see subversion results). I am unsure why those are skipped without any details.

@jglick

This comment has been minimized.

Copy link
Member Author

jglick commented Aug 10, 2016

Hmm,

Skipping linearFlow(plugins.WorkflowPluginTest)
org.junit.internal.AssumptionViolatedException: junit has version 1.15 but 1.18 was requested
    at org.jenkinsci.test.acceptance.po.PluginManager.installPlugins(PluginManager.java:199)
    at org.jenkinsci.test.acceptance.junit.WithPlugins$RuleImpl$1.doInstall(WithPlugins.java:141)
    at org.jenkinsci.test.acceptance.junit.WithPlugins$RuleImpl$1.installPlugins(WithPlugins.java:128)

I suspect that when the test ran, the update center had not yet been refreshed. Build 950 did pass, with junit 1.15. (1.18 is required when running against Jenkins 1.x.)

@jglick jglick merged commit c52db71 into jenkinsci:master Aug 10, 2016

1 check failed

Jenkins Looks like there's a problem with this pull request
Details

@jglick jglick deleted the jglick:symbol-JENKINS-29922 branch Aug 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.