Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-26192] Demonstrating @Grab support in a realistic class loader environment #176

Merged
merged 2 commits into from Aug 31, 2016

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 19, 2016

Downstream of jenkinsci/workflow-cps-global-lib-plugin#9.

@reviewbybees

@ghost
Copy link

ghost commented Aug 19, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@rsandell
Copy link
Member

🐝

@abayer
Copy link
Member

abayer commented Aug 30, 2016

🐝

@jglick
Copy link
Member Author

jglick commented Aug 30, 2016

@reviewbybees done

@ghost
Copy link

ghost commented Aug 30, 2016

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

@olivergondza olivergondza merged commit cf30b67 into jenkinsci:master Aug 31, 2016
@jglick jglick deleted the Grape-JENKINS-26192 branch September 6, 2016 13:33
@jglick
Copy link
Member Author

jglick commented Sep 6, 2016

This was not supposed to be merged before workflow-cps-global-lib@2.3 was actually released! Apparently @WithPlugins does not work properly: the test should get skipped unless and until the specified version of the plugin is available.

@olivergondza
Copy link
Member

Right, the annotation is not ready for that: JENKINS-38015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants