New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multiple servers without assigned ports #19

Merged
merged 1 commit into from Mar 3, 2016

Conversation

Projects
None yet
3 participants
@nieuwtje

nieuwtje commented Feb 5, 2016

Whenever multiple domain controllers are defined, but they don't have a port assigned, only the last domain controller was given a port -> Added support for multiple servers without assigned ports.

@jtnord

This comment has been minimized.

Show comment
Hide comment
@jtnord

jtnord Feb 5, 2016

Member

code LGTM - but the history would be a little unclear due to the merge in the ancestry. Can you rebase the change ontop of origin/master?

Member

jtnord commented Feb 5, 2016

code LGTM - but the history would be a little unclear due to the merge in the ancestry. Can you rebase the change ontop of origin/master?

@jenkinsadmin

This comment has been minimized.

Show comment
Hide comment
@jenkinsadmin

jenkinsadmin Feb 5, 2016

Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

Member

jenkinsadmin commented Feb 5, 2016

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@jtnord

This comment has been minimized.

Show comment
Hide comment
@jtnord
Member

jtnord commented Mar 3, 2016

@fbelzunc FYI.

jtnord added a commit that referenced this pull request Mar 3, 2016

Merge pull request #19 from nieuwtje/multiple-domain-add-ports-if-mis…
…sing

Added support for multiple servers without assigned ports

@jtnord jtnord merged commit 5372151 into jenkinsci:master Mar 3, 2016

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment