Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a view column for the total warnings count #4

Merged
merged 4 commits into from Sep 16, 2014

Conversation

Projects
None yet
2 participants
@sschuberth
Copy link
Contributor

commented Sep 16, 2014

sschuberth added some commits Sep 16, 2014

Upgrade analysis-core to the latest version 1.59
Future commits will depend on the WarningsCountColumn class which was
introduced in analysis-core version 1.54.
Adapt tests to analysis-core 1.59
analysis-core now already escapes the issue message in the
AbstractAnnotation constructor, so do not do it ourselves.

However, as StringEscapeUtils.escapeXml() instead of
StringEscapeUtils.escapeHtml() is being used, we also need to replace the
single quotes with ' in testParser_post_r21().
Use StringEscapeUtils.escapeXml() instead of escapeHtml() in all places
This is not strictly required for fixing tests, but for consistency with
analysis-core.

Also, the Lint results file in fact is XML instead of HTML, so escapeXml()
is the more appropriate method.

orrc added a commit that referenced this pull request Sep 16, 2014

Merge pull request #4 from sschuberth/master
Add a view column for the total warnings count

@orrc orrc merged commit 0fc2391 into jenkinsci:master Sep 16, 2014

1 check passed

default This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.