Skip to content
Browse files

adding download links

  • Loading branch information...
1 parent acf5bd6 commit 9e844e472bf4c3f1c1ea41b4b501c7e2da394030 @kohsuke kohsuke committed Oct 29, 2012
Showing with 6 additions and 5 deletions.
  1. +6 −5 src/main/java/org/jenkinsci/confluence/plugins/JenkinsPluginInfoMacro.java
View
11 src/main/java/org/jenkinsci/confluence/plugins/JenkinsPluginInfoMacro.java
@@ -161,10 +161,11 @@ public String execute(Map parameters, String body, RenderContext renderContext)
}
{// second row
+ String requiredCore = getString(pluginJSON, "requiredCore");
toBeRendered.append(" || Latest Release \\\\ Latest Release Date \\\\ Required Core \\\\ Dependencies | ")
- .append(version)
+ .href(version,"http://updates.jenkins-ci.org/latest/"+name+".hpi").append(" ").href("(archives)","http://updates.jenkins-ci.org/download/plugins/"+name+"/")
@lacostej
Jenkins member
lacostej added a note Nov 26, 2012

Could that cause problems with .jpi files ?

@imod
Jenkins member
imod added a note Nov 26, 2012

definitely would, we should get the correct extension from the maven "gav" coordinates

@kohsuke
Jenkins member
kohsuke added a note Nov 27, 2012

For uniformity, the update center server uses *.hpi for all artifacts, so this works. If you find a problematic URL, let me know.

@imod
Jenkins member
imod added a note Nov 27, 2012

@kohsuke I do agree, but the time we changed the core to store all plugins with the extenion *.jpi, we where also discussing to update the maven plugin to create jpi files in the future. I know this is not done yet, but I think we should look into this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
.br().append(getString(pluginJSON, "buildDate"))
- .br().append(getString(pluginJSON, "requiredCore"))
+ .br().href(requiredCore,"http://updates.jenkins-ci.org/download/war/"+requiredCore+"/jenkins.war")
.br().append(getDependencies(updateCenter, pluginJSON))
@@ -192,7 +193,7 @@ public String execute(Map parameters, String body, RenderContext renderContext)
devString.append(devName);
}
- devString.print(" (id: %s)",devId);
+ devString.print(" (id: %s)", devId);
}
}
@@ -255,10 +256,10 @@ private String getDependencies(JSONObject updateCenter, JSONObject pluginJSON) t
String depWikiUrl = getWikiUrl(updateCenter, depName);
if (depString.length()>0)
- depString.append(" \\\\ ");
+ depString.br();
if (depWikiUrl.length() > 0) {
- depString.href(depName,depWikiUrl);
+ depString.href(depName, depWikiUrl);
} else {
depString.append(depName);
}

0 comments on commit 9e844e4

Please sign in to comment.
Something went wrong with that request. Please try again.