Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-48279# Update start of page in directory listing #93

Merged
merged 1 commit into from Dec 12, 2017

Conversation

vivek
Copy link
Contributor

@vivek vivek commented Dec 12, 2017

Increment page start parameter during recursive call to fetch directory listing page. This can cause the loop to never break for repo directory with number of files > 500.

See https://issues.jenkins-ci.org/browse/JENKINS-48279.

cc: @Casz @stephenc

@vivek vivek changed the title JENKINS-48279# Increment start of page in directory listing JENKINS-48279# Update start of page in directory listing Dec 12, 2017
@michaelneale
Copy link
Member

LGTM

Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vivek
Copy link
Contributor Author

vivek commented Dec 12, 2017

@stephenc @amuniz Its ready for merge. Maybe a release with this fix will be good as it might cause trouble to users with > 500 files in the repo.

@jetersen
Copy link
Member

@vivek I think @rsandell is the new shepherd :)

@vivek
Copy link
Contributor Author

vivek commented Dec 12, 2017

@Casz thanks:) @rsandell PTAL.

@jetersen
Copy link
Member

#90 for reference does say it's Robert who's the new shepherd 👍

@stephenc stephenc merged commit b34bd66 into jenkinsci:master Dec 12, 2017
fengxx pushed a commit to fengxx/bitbucket-branch-source-plugin that referenced this pull request Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants