[FIX JENKINS-39842] Open Blue Ocean button should not try to load /activity for a folder #96
Conversation
Clicking on the "Open Blue Ocean" button while in a classic folder that's not a MBP project folder should bring the user to the main top-level blue ocean page i.e. pipelines
|
|
||
| // Go to a folder along the path to the MBP, but one | ||
| // of the parent folders i.e. not the MBP project folder. | ||
| classicGeneral.navigateToRun('job/anotherFolder/job/三百/job/ñba'); |
There was a problem hiding this comment.
why not to job/anotherFolder ? Maybe also test that?
There was a problem hiding this comment.
We could, but not needed imo i.e. the main thing is that it's not the MBP folder at the end of the path.
|
Confusing folder for the layperson, maybe just simplify? |
|
Okay ... let me see if I can create a separate test completely that just tests this. Seemed a bit overkill when I was doing it (piggybacking was easier), but what the heck :) |
|
I mean... why would you include random UTF characters for a folder? it's confusing to tell what it even represents. Just use a basic folder for this test, wouldn't that make the most sense? |
|
@kzantow that folder structure was already there and, I assume, the weird characters were added so as to test url encodings when strange characters are in use i.e. it's a good idea having them in the test. |
|
Tbh, I found the strange chars to be more interesting than confusing, when I first saw it there. What do they mean ... no idea ... doesn't matter ... they're just characters in a file path... who cares?? I seriously doubt you find it all that confusing either hehehe 😉 |
|
@kzantow I'm creating another test here that has a folder path structure using chars ... hang fire ... c&p in action 😉 |
Using folder and job/branch names that are not confusing (special chars etc). BTW I'm leaving the original tests that were using weird chars because I think it's good to have tests that challenge the url encoding etc. Sure that can result in the presence of weird chars, but weird chars are a fact of life, so good to test against them.
|
@kzantow another test added that's using more "normal" characters. However I'm keeping the original tests because imo it's good to have tests using "weird" chars. |
|
@kzantow thanks for the review bud!! |
Description
Test for jenkinsci/blueocean-plugin#685
Clicking on the "Open Blue Ocean" button while in a classic folder that's not a MBP project folder should bring the user to the main top-level blue ocean page i.e. pipelines
See JENKINS-39842.
Submitter checklist
Reviewer checklist
@reviewbybees