Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-47888 make run button visible on the PR tab #1539

Merged
merged 1 commit into from Nov 9, 2017

Conversation

2 participants
@NicuPascu
Copy link
Collaborator

commented Nov 8, 2017

Make the run button visible on the PR tab (it was white against the white background making it invisible)

See JENKINS-47888.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@NicuPascu NicuPascu requested a review from sophistifunk Nov 8, 2017

@NicuPascu

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 8, 2017

Before:
run-button-pr-tab

After:
run-button-pr-tab-fixed

@@ -37,6 +37,14 @@
position: absolute;
top: 0;
left: 0;

.ParametersRunButton & {
fill: rgba(53, 64, 82, 0.25);

This comment has been minimized.

Copy link
@sophistifunk

sophistifunk Nov 9, 2017

Collaborator

Where do these values come from?

This comment has been minimized.

Copy link
@NicuPascu

NicuPascu Nov 9, 2017

Author Collaborator

I added the same colours as the history button that is beside it, it gets them from here https://github.com/jenkinsci/blueocean-plugin/blob/master/blueocean-dashboard/src/main/less/history-button.less#L14

This comment has been minimized.

Copy link
@sophistifunk

sophistifunk Nov 9, 2017

Collaborator

👍

@sophistifunk

This comment has been minimized.

Copy link
Collaborator

commented Nov 9, 2017

LGTM 🐝

@NicuPascu NicuPascu merged commit f819eeb into master Nov 9, 2017

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@NicuPascu NicuPascu deleted the bug/JENKINS-47888_run_button_not_visible_pr_tab branch Nov 9, 2017

NicuPascu added a commit that referenced this pull request Nov 15, 2017

NicuPascu added a commit that referenced this pull request Nov 16, 2017

fix favourites run button colour that was broken in #1539 (#1555)
* fix favourites run button colour that was broken in #1539

* fix mail link and folder colours
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.