Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-48872# Fix deserialization error for missing ModelObject field #1614

Merged
merged 2 commits into from Jan 10, 2018

Conversation

3 participants
@vivek
Copy link
Collaborator

commented Jan 10, 2018

Description

ModelObject was serialized in prior version (1.4.0-beta4 and older), it was removed as part of fix that went in PR #1609. This caused error reported in OldData. Fix is to simply put back unused ModelObject as transient.

@michaelneale @jglick Do not like this fix, is there better ways other plugins handle it? On the other hand, we could mark this issue as will not fix as 'Discard Unreadable Data' is just fine. Just that it will surprise anyone upgrading to 1.4.0 and we might want to port #1609 to 1.3.0.

See JENKINS-48872.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@vivek vivek added the needs-review label Jan 10, 2018

@michaelneale

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

yeah maybe @jglick know of a @PleaseIgnore type annotation to make this go away, but this while unpleasant might do the trick (perhaps with a comment that it can be removed in a future version)

@michaelneale

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

🐝

@abayer

abayer approved these changes Jan 10, 2018

Copy link
Member

left a comment

Seems reasonable to me.

@vivek vivek merged commit c915aad into master Jan 10, 2018

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@vivek vivek deleted the bug/JENKINS-48872_modelobject-missingfield branch Jan 10, 2018

michaelneale added a commit that referenced this pull request Feb 13, 2018

JENKINS-48872# Fix deserialization error for missing ModelObject field (
#1614)

* JENKINS-48872# Fix deserialization error for missing ModelObject field

* Findbug fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.