Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-47022 - Fix for dropdown losing focus on selection, back port to 1.4 #1660

Merged
merged 2 commits into from Feb 16, 2018

Conversation

@vivek
Copy link
Collaborator

commented Feb 16, 2018

Description

Backport of #1652 and #1654 to release/1.4.

See JENKINS-47022.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given
NicuPascu added 2 commits Feb 12, 2018
JENKINS-47022 - Fix for dropdown losing focus on selection (#1652)
* on IE, restore focus on dropdown button after selection

* force the dropdown to regain focus after selection on all browsers

* add test to verify that the dropdown component retains focus after option selection

@vivek vivek requested review from cliffmeyers, kzantow and scherler as code owners Feb 16, 2018

@vivek vivek added the needs-review label Feb 16, 2018

@kzantow
Copy link
Collaborator

left a comment

👍

@vivek vivek merged commit 67f32ec into release/1.4 Feb 16, 2018

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@vivek vivek deleted the JENKINS-47022_backport-1.4 branch Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.