Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide BlueOceanExportInterceptor so Javadoc can ignore .export package #1666

Merged
merged 1 commit into from Feb 21, 2018

Conversation

3 participants
@sophistifunk
Copy link
Collaborator

commented Feb 20, 2018

Description

Hide BlueOceanExportInterceptor so Javadoc can ignore .export package

@sophistifunk

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 20, 2018

Pain to bytes ratio is way out on this one

@michaelneale

This comment has been minimized.

Copy link
Member

commented Feb 20, 2018

@sophistifunk WOW - so this was it?
And this one even attempted to take out your hard drive? the javadoc thing REALLY hates everyone doesn't it.

cc @vivek @raul-arabaolaza

@sophistifunk

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 20, 2018

I blame Oracle for whatever the hell Idea happened to do to my kernel that required a reboot and triggered the drive hiccups. I've never seen ps aux give a stat of ?E before.

@michaelneale

This comment has been minimized.

Copy link
Member

commented Feb 20, 2018

@sophistifunk I have seen all sorts of weird things in the early days of AWS EBS, when things would flame out in the most novel ways, sounded a bit like that. Combination of hardware and low level software failures.

/me stares into the jungle

@sophistifunk

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 20, 2018

...something, something Tannhauser Gate....

@sophistifunk

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 20, 2018

Re-running build

@sophistifunk

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 20, 2018

Different ATH test failing, so re-running again....

@michaelneale

This comment has been minimized.

Copy link
Member

commented Feb 21, 2018

OK with me if ok with @vivek - no chance anyone external is depending on this I would hope?

@vivek

This comment has been minimized.

Copy link
Collaborator

commented Feb 21, 2018

@sophistifunk Great sleuthing! This is best solution. This class is only for internal use so all good. Tried locally, works well. Also tested case where there is java doc error in non-stapler blueocean code in blueocean-commins, the doc error is reported.

LGTM 🐝

@vivek

vivek approved these changes Feb 21, 2018

@sophistifunk sophistifunk merged commit 3beb5db into master Feb 21, 2018

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@halkeye halkeye deleted the task/fix-javadoc-warning branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.