Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-53697] #1815

Merged
merged 2 commits into from Sep 29, 2018

Conversation

2 participants
@runzexia
Copy link
Member

runzexia commented Sep 29, 2018

Description

See JENKINS-53697.

init scmSource

runzexia added some commits Sep 29, 2018

fix
@olamy

This comment has been minimized.

Copy link
Member

olamy commented Sep 29, 2018

@runzexia great job! I wonder if there is a way to have a unit reproducing the issue?

@runzexia

This comment has been minimized.

Copy link
Member Author

runzexia commented Sep 29, 2018

curl -X PUT \
  http://127.0.0.1:8080/jenkins/blue/rest/organizations/jenkins/scm/git/validate/ \
  -H 'Cache-Control: no-cache' \
  -H 'Content-Type: application/json' \
  -d '{
	"repositoryUrl":"https://github.com/jenkinsci/blueocean-plugin",
	"branch":"master",
	"requirePush":true,
	"userName":"xxxxx",
	"password":"xxxxx"
}
'

@olamy

@olamy

This comment has been minimized.

Copy link
Member

olamy commented Sep 29, 2018

well I mean a unit test :)

@runzexia

This comment has been minimized.

Copy link
Member Author

runzexia commented Sep 29, 2018

well I mean a unit test :)

I need a git repository to perform unit test. I don't know how to add it. Do you have any suggestions?

@olamy

This comment has been minimized.

Copy link
Member

olamy commented Sep 29, 2018

@runzexia oh sure this might be complicated :)

@olamy olamy merged commit 2cedce9 into jenkinsci:master Sep 29, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@runzexia runzexia deleted the runzexia:fix-JENKINS-53697 branch Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.