Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-46193 - Add support for filtering out non regressed failures. #1938

Merged
merged 3 commits into from Mar 26, 2019

Conversation

3 participants
@halkeye
Copy link
Collaborator

commented Mar 21, 2019

Summary does it, frontend needs to do it too.

Also included ability to filter by age

Description

See JENKINS-46193.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • [] Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given
@halkeye

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 21, 2019

I feel bad about including the age filter. I ended up doing the !REGRESSED support instead as its closer to summary. But I also didn't want to throw it away.

@halkeye

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 21, 2019

JENKINS-46193.zip

if you want to test, i just pulled the job that was originally mentioned in the ticket locally

@sophistifunk
Copy link
Collaborator

left a comment

Java all looks good, scope nitpicking aside. Feel free to ignore me where I'm wrong 😁

halkeye added some commits Mar 21, 2019

JENKINS-46193 - Add support for filtering out non regressed failures.
Summary does it, frontend needs to do it too.

Also included ability to filter by age

@halkeye halkeye force-pushed the JENKINS-46193-newly-regressed-excluded branch from b4660cc to 57fe2d0 Mar 22, 2019

@sophistifunk

This comment has been minimized.

Copy link
Collaborator

commented Mar 25, 2019

LGTM 🐝 I have NFI how to make github record an approval, I've never found the button. Not sure if I'm missing a chromosome, or UI is just that poorly thought through.

notsure

@NicuPascu
Copy link
Collaborator

left a comment

LGTM

@halkeye halkeye merged commit 53ebf9b into master Mar 26, 2019

3 checks passed

continuous-integration/blueocean/branch This commit looks good
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/incrementals Deployed to Incrementals.
Details

@halkeye halkeye deleted the JENKINS-46193-newly-regressed-excluded branch Mar 26, 2019

@halkeye halkeye added the bug label Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.