Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check read permission for sidebar link #2086

Merged
merged 2 commits into from Aug 27, 2020

Conversation

hughsaunders
Copy link
Contributor

@hughsaunders hughsaunders commented Aug 13, 2020

Theres no need, because the user wouldn't be viewing
the build page if they didn't have the required read permission.

Description

See JENKINS-46540.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Theres no need, because the user wouldn't be viewing
the build page if they didn't have the required read permission.

Related: JENKINS-46540
@hughsaunders
Copy link
Contributor Author

hughsaunders commented Aug 14, 2020

The three tests that failed, also failed in master eg buid 1898 and I don't think they are related to my PR.

@hughsaunders
Copy link
Contributor Author

Hey @daniel-beck thanks for the approval, does this need another approval before merge?

@daniel-beck
Copy link
Member

I do not maintain this. It only looks like I'm a maintainer with the green checkmark, but that's because I'm an org owner.

@hughsaunders
Copy link
Contributor Author

@bitwiseman Hey, is there anything else I need to do to enable this to be merged?

@bitwiseman
Copy link
Contributor

@hughsaunders
Thanks!

@bitwiseman bitwiseman merged commit 070eee7 into jenkinsci:master Aug 27, 2020
@bitwiseman bitwiseman added the bug label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants