Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-33106] Dynamic CustomOrganizationFolderDescriptor registration #30

Merged
merged 2 commits into from Mar 11, 2016

Conversation

Projects
None yet
6 participants
@jglick
Copy link
Member

commented Mar 11, 2016

@@ -64,8 +64,7 @@
</scm>

<properties>
<jenkins.version>1.609.1</jenkins.version>
<java.level>6</java.level>
<jenkins.version>1.625.1</jenkins.version>

This comment has been minimized.

Copy link
@jglick

jglick Mar 11, 2016

Author Member

Needed for ExtensionListListener.

This comment has been minimized.

Copy link
@recena

recena Mar 11, 2016

Collaborator

👍

@reviewbybees

This comment has been minimized.

Copy link

commented Mar 11, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Mar 11, 2016

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@recena

This comment has been minimized.

Copy link
Collaborator

commented Mar 11, 2016

@jglick LGTM but I don't have enough experience in this part.

@kohsuke

This comment has been minimized.

Copy link
Member

commented Mar 11, 2016

Unrelated to the fix at hand, but what the core needs is a listener who gets notified of a new extension when it's loaded dynamically.

Oh, scratch that, it's already there.

@kohsuke

This comment has been minimized.

Copy link
Member

commented Mar 11, 2016

🐝

1 similar comment
@andresrc

This comment has been minimized.

Copy link

commented Mar 11, 2016

🐝

jglick added a commit that referenced this pull request Mar 11, 2016

Merge pull request #30 from jglick/dynamic-load-JENKINS-33106
[JENKINS-33106] Dynamic CustomOrganizationFolderDescriptor registration

@jglick jglick merged commit 61ec9d9 into jenkinsci:master Mar 11, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:dynamic-load-JENKINS-33106 branch Mar 11, 2016

@jglick jglick referenced this pull request Mar 14, 2016

Merged

Jenkins baseline bump #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.