Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-32782] Empty view did not show delete link #31

Merged
merged 1 commit into from Mar 11, 2016

Conversation

Projects
None yet
5 participants
@jglick
Copy link
Member

commented Mar 11, 2016

JENKINS-32782

Corrects handling of view identity which I commented on in #17.

@reviewbybees esp. @stephenc, @kzantow

@jglick

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2016

By the way this is the code calling equals in this case.

@kzantow

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2016

🐝

1 similar comment
@recena

This comment has been minimized.

Copy link
Collaborator

commented Mar 11, 2016

🐝

@reviewbybees

This comment has been minimized.

Copy link

commented Mar 11, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2016

@reviewbybees done

(@stephenc will need your assistance today I think)

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Mar 11, 2016

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

jglick added a commit that referenced this pull request Mar 11, 2016

Merge pull request #31 from jglick/BaseEmptyView.equals-JENKINS-32782
[JENKINS-32782] Empty view did not show delete link

@jglick jglick merged commit 2c30f50 into jenkinsci:master Mar 11, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:BaseEmptyView.equals-JENKINS-32782 branch Mar 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.