Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-34239] JENKINS-33106 fix was sensitive to plugin installation ordering #49

Merged
merged 1 commit into from Sep 2, 2016

Conversation

@jglick
Copy link
Member

jglick commented Sep 2, 2016

JENKINS-34239

Amends #30 by fixing the reverse case.

@reviewbybees

…a MultiBranchProjectFactoryDescriptor is added first, then a SCMNavigatorDescriptor.
@@ -122,6 +122,7 @@ public static void addSpecificDescriptors() {
LOGGER.fine("ran addSpecificDescriptors");
doAddSpecificDescriptors();
ExtensionList.lookup(MultiBranchProjectFactoryDescriptor.class).addListener(new ListenerImpl());
ExtensionList.lookup(SCMNavigatorDescriptor.class).addListener(new ListenerImpl());

This comment has been minimized.

Copy link
@recena

recena Sep 2, 2016

Collaborator

👍

@recena

This comment has been minimized.

Copy link
Collaborator

recena commented Sep 2, 2016

🐝

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Sep 2, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@abayer

This comment has been minimized.

Copy link
Member

abayer commented Sep 2, 2016

🐝

@jglick jglick merged commit 78766a8 into jenkinsci:master Sep 2, 2016
1 check passed
1 check passed
Jenkins This pull request looks good
Details
@jglick jglick deleted the jglick:JENKINS-34239-dynamicLoadReversed branch Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.