New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixed JENKINS-14591] migrate parameter options to extensible behavior #96
Conversation
Rename config to 'row header' and 'column header' options. Provide different options based on existing behavior and requests from users: * No column header * Simple headers * Headers with parameters * Header with all build variables
cc @recena |
// dropdownDescriptorSelectors will fill items up but don't update the layout, so need | ||
// to do that explicitly | ||
setTimeout(function(){ | ||
layoutUpdateCallback.call(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was annoying AF - without this, the 'save / ok' button will overlap on the fields. If there's a better way to do it I'm open to it.
@@ -241,6 +241,7 @@ | |||
<goals> | |||
<goal>check</goal> | |||
</goals> | |||
<phase>process-classes</phase> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done - I think it is worth doing (checkstyle after tests is a bit of a bummer), but will put that in another PR
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
Conflicts: src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
Finally got around to fixing the merge conflict! Testing looks good. @recena you've already reviewed, but it's so long ago that I want to check: are you 👍 for me to merge? |
JENKINS-14591
Rename config to 'row header' and 'column header' options. Provide different
options based on existing behavior and requests from users:
Refactored these options to encapsulate the UI logic better - no more large if / else blocks in
bpp.jelly
, they belong to their own classes now. Users can now provide their own@Extension
ofPipelineHeaderExtension
to customize, following open-closed principle.