Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-22974] - NPE in makeUserVars if an upstream build is missing #4

Merged
merged 2 commits into from May 19, 2014

Conversation

Projects
None yet
5 participants
@oleg-nenashev
Copy link
Member

oleg-nenashev commented May 13, 2014

The PR contains the bugfix and the direct test case.
AFAIK, the newest Jenkins core versions contain annotations for Job::getBuildByNumber(), hence developers will be notified about such issues.

oleg-nenashev added some commits May 13, 2014

[JENKINS-22974] - Added a test case for the issue
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
[FIXED JENKINS-22974] - Check for non-existent upstream builds
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented May 13, 2014

plugins » build-user-vars-plugin #9 SUCCESS
This pull request looks good

@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

oleg-nenashev commented May 13, 2014

Hmm... Jenkins Core does not have such annotations. Just an additional TODO...

@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented May 13, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

clifford-github added a commit that referenced this pull request May 19, 2014

Merge pull request #4 from synopsys-arc-oss/JENKINS_22974_NPE_in_make…
…UserVars

[FIXED JENKINS-22974] - NPE in makeUserVars if an upstream build is missing

@clifford-github clifford-github merged commit 5db4ca0 into jenkinsci:master May 19, 2014

@xasx

This comment has been minimized.

Copy link

xasx commented on 223500f Aug 26, 2014

Should really be released, please.

https://issues.jenkins-ci.org/browse/JENKINS-24439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.