[WIP]Make compatible with pipelines #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjorando
changed the title
rsandell
reviewed
Nov 30, 2017
| @@ -112,4 +118,40 @@ public String getMetricFilePath() { | |||
| return metricFilePath; | |||
| } | |||
|
|
|||
| @Override | |||
| public void perform(@Nonnull Run<?, ?> run, @Nonnull FilePath filePath, @Nonnull Launcher launcher, @Nonnull TaskListener taskListener) { | |||
There was a problem hiding this comment.
This should replace the old perform method iirc, not added as an extra.
rsandell
reviewed
Nov 30, 2017
| @@ -223,4 +224,8 @@ public void setResultFilePath(FilePath resultFilePath) { | |||
| this.resultFilePath = resultFilePath; | |||
| } | |||
|
|
|||
| @Override | |||
| public void checkRoles(RoleChecker roleChecker) throws SecurityException { | |||
There was a problem hiding this comment.
Extend MasterToSlaveFileCallable instead of implementing your own role checker.
https://wiki.jenkins.io/display/JENKINS/Slave+To+Master+Access+Control#SlaveToMasterAccessControl-I'maplugindeveloper.WhatshouldIdo?
There was a problem hiding this comment.
Oh, this is part of the legacy code I didn't change. But I can modify that too.
added 3 commits
December 1, 2017 11:24
|
@rsandell Thank you for your comments, I did the requested modifications and tested them. |
|
👍 LGTM |
|
Though you should add a few tests that use a pipeline job to verify it works as intended :) |
|
Ok! I'll add some tests, and update the README file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to get the plug-in to work with the (not so) new pipeline/workflow system of Jenkins. Since the repo hasn't been updated for a looot of time, there are also some dependencies updates.
I'd appreciate some feedback, as I'm not at all a expert Jenkins API programer nor a specialist of Jenkins it self. For what I tested on my own instance, my commits don't seem to break the plug-in. :)
TODO:
performmethodCcccParser, extendMasterToSlaveFileCallableinstead of overridingcheckRoles.