New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified zip file size to 2,147,483,647 which is 2^31-1. this allows … #3

Open
wants to merge 1 commit into
base: release_8.1.0-2
from

Conversation

Projects
None yet
3 participants
@Th3R3p0

Th3R3p0 commented Sep 20, 2016

The current "209715200" is an arbitrary number and the plugin supports up to "2147483647." Tested this in Jenkins and Checkmarx (IIS with modified maximum upload size) and it works successfully.

See the following link for full write up: http://www.th3r3p0.com/debugging/checkmarx+jenkins+plugin.html

modified zip file size to 2,147,483,647 which is 2^31-1. this allows …
…a zip file larger than 200mb to be uploaded to the checkmarx server.
@imatlin

This comment has been minimized.

imatlin commented Oct 4, 2016

There is no need to upload zip files of that size: source code compresses very well, and it takes an extremely large application to exceed 200MB of compressed code. Uploading large zip files to Cx server results in unnecessary network overhead, and increases scan time significantly - since the files have to be unzipped on the server and non-scannable files have to be filtered out first.

If you run into 200MB limitation, please check that non-scannable files are properly excluded by modifying include/exclude settings of the project.

@mbaluda

This comment has been minimized.

mbaluda commented Mar 8, 2018

I have the same issue, the zip is created from source file only.
Please merge in the official plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment