Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to suppress log in job summary #93

Merged
merged 3 commits into from
Mar 8, 2021

Conversation

mrginglymus
Copy link
Contributor

Fixes #92

I ummed and ahhed a bit over whether to have suppressLogs vs includeLogs but I went with true == override default behaviour (with the assumption that most people do want logs).

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right

@mrginglymus
Copy link
Contributor Author

mrginglymus commented Mar 5, 2021

There's a leak in our ChecksProperties test extension.

Copy link
Contributor

@XiongKezhi XiongKezhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the test failures and pmd warnings.

@mrginglymus
Copy link
Contributor Author

Not sure on those test failures given it works on my machine and Jenkins test infra; I think GitHub got confused by the ninja force push.

@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #93 (dfdd569) into master (bf2e07e) will increase coverage by 0.03%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #93      +/-   ##
============================================
+ Coverage     85.90%   85.94%   +0.03%     
- Complexity      150      151       +1     
============================================
  Files            17       17              
  Lines           731      733       +2     
  Branches         54       55       +1     
============================================
+ Hits            628      630       +2     
  Misses           85       85              
  Partials         18       18              
Impacted Files Coverage Δ Complexity Δ
.../checks/status/AbstractStatusChecksProperties.java 42.85% <0.00%> (-7.15%) 1.00 <0.00> (ø)
...s/plugins/checks/status/FlowExecutionAnalyzer.java 81.25% <85.71%> (+0.83%) 45.00 <0.00> (+1.00)
...gins/checks/status/BuildStatusChecksPublisher.java 80.26% <100.00%> (ø) 14.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf2e07e...7060892. Read the comment docs.

@mrginglymus mrginglymus force-pushed the no-logs branch 2 times, most recently from 316d53f to 7060892 Compare March 6, 2021 10:52
@XiongKezhi XiongKezhi merged commit d493f98 into jenkinsci:master Mar 8, 2021
@XiongKezhi
Copy link
Contributor

Not sure on those test failures given it works on my machine and Jenkins test infra; I think GitHub got confused by the ninja force push.

Passed on my local machine, but still failed in java 11 build after merging this. Maybe it's a java 11 build problem, I'll test it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Option to NOT expose build logs
3 participants