New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Chuck to background image on newer Jenkins. #6

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@edgibbs
Contributor

edgibbs commented Dec 25, 2014

This is to fix the issue we saw as well with Chuck not appearing in recent Jenkins. Referenced in this bug:

https://issues.jenkins-ci.org/browse/JENKINS-25084

'main-table' does not exist in newer Jenkins, but I kept a check in for it for backwards compatibility. Love this plugin by the way, it's my been my first install after Hudson/Jenkins for many years.

@jenkinsadmin

This comment has been minimized.

Show comment
Hide comment
@jenkinsadmin

jenkinsadmin Dec 25, 2014

Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Member

jenkinsadmin commented Dec 25, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@edgibbs

This comment has been minimized.

Show comment
Hide comment
@edgibbs

edgibbs Dec 25, 2014

Contributor

Looked into the build failure since only two jelly templates actually changed and it was all css/javascript changes in those templates. It blows up on a maven dependency for httpcore. Looking at the prior successful build from two months ago, this build pulls in a lot more dependencies in the console log.

I can run tests through maven successfully locally as well. Maybe another build attempt will resolve?

Contributor

edgibbs commented Dec 25, 2014

Looked into the build failure since only two jelly templates actually changed and it was all css/javascript changes in those templates. It blows up on a maven dependency for httpcore. Looking at the prior successful build from two months ago, this build pulls in a lot more dependencies in the console log.

I can run tests through maven successfully locally as well. Maybe another build attempt will resolve?

@eunikolsky

This comment has been minimized.

Show comment
Hide comment
@eunikolsky

eunikolsky Feb 10, 2015

@edgibbs, thanks for the fix!

eunikolsky commented Feb 10, 2015

@edgibbs, thanks for the fix!

@pnathan

This comment has been minimized.

Show comment
Hide comment
@pnathan

pnathan May 30, 2015

👍 can we get a fix on this merged in?

pnathan commented May 30, 2015

👍 can we get a fix on this merged in?

@edgibbs

This comment has been minimized.

Show comment
Hide comment
@edgibbs

edgibbs Jun 5, 2015

Contributor

I'm still up for adding any extra needed changes, I can't resolve the build failure because I don't have enough details and my change seemed unrelated.

Contributor

edgibbs commented Jun 5, 2015

I'm still up for adding any extra needed changes, I can't resolve the build failure because I don't have enough details and my change seemed unrelated.

@daniel-beck daniel-beck reopened this Jun 10, 2015

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Jun 10, 2015

Member

Closed and reopened the PR to trigger a new PR build.

Member

daniel-beck commented Jun 10, 2015

Closed and reopened the PR to trigger a new PR build.

@ludicruz

This comment has been minimized.

Show comment
Hide comment
@ludicruz

ludicruz Jun 25, 2015

👍 When can this be released? :)
Chuck Norris does not ask for pull requests, Chuck Norris round house kicks into the repo.

ludicruz commented Jun 25, 2015

👍 When can this be released? :)
Chuck Norris does not ask for pull requests, Chuck Norris round house kicks into the repo.

@recurrence

This comment has been minimized.

Show comment
Hide comment
@recurrence

recurrence Oct 15, 2015

Chuck Norris does not need to merge his code. The other code needs to merge with Chuck Norris.

recurrence commented Oct 15, 2015

Chuck Norris does not need to merge his code. The other code needs to merge with Chuck Norris.

@pnathan

This comment has been minimized.

Show comment
Hide comment
@pnathan

pnathan Oct 16, 2015

can there be a roundhouse kick of getting this working?

pnathan commented Oct 16, 2015

can there be a roundhouse kick of getting this working?

@batmat

This comment has been minimized.

Show comment
Hide comment
@batmat

batmat Nov 2, 2015

Member

Woops, sorry I missed this PR when working on it yesterday. This issue is deemed fixed with release 0.9 published a few hours ago.

Hence, I'm gonna close this PR. Feel free to comment/reopen if there's something still missing, or possibly give feedback if the 0.9 actually fixes the issue for you too.

Thanks

Member

batmat commented Nov 2, 2015

Woops, sorry I missed this PR when working on it yesterday. This issue is deemed fixed with release 0.9 published a few hours ago.

Hence, I'm gonna close this PR. Feel free to comment/reopen if there's something still missing, or possibly give feedback if the 0.9 actually fixes the issue for you too.

Thanks

@batmat batmat closed this Nov 2, 2015

@batmat

This comment has been minimized.

Show comment
Hide comment
@batmat

batmat Nov 2, 2015

Member

https://issues.jenkins-ci.org/browse/JENKINS-25084 for the record.
Some people report it fixed their issue. Some don't... Please test and report to provide data to reproduce issue if possible. Thanks

Member

batmat commented Nov 2, 2015

https://issues.jenkins-ci.org/browse/JENKINS-25084 for the record.
Some people report it fixed their issue. Some don't... Please test and report to provide data to reproduce issue if possible. Thanks

@batmat

This comment has been minimized.

Show comment
Hide comment
@batmat

batmat Nov 2, 2015

Member

Finally reused your commit @edgibbs, works better. Gonna release a 0.9.1 soon.
Thanks

Member

batmat commented Nov 2, 2015

Finally reused your commit @edgibbs, works better. Gonna release a 0.9.1 soon.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment